hotfix(rstudio): add correct frame options #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rstudio is served in an Iframe, we need to enable iframes
|
✨ Coder.com for PR #647 deployed! It will be updated on every commit.
|
|
[sc-17709] |
|
This pull request has been linked to Shortcut Story #17709: RStudio (REGRESSION): Can't open RStudio through Dashboard. |
greyscaled
reviewed
Oct 5, 2021
| @@ -230,6 +230,7 @@ RStudio: | |||
| RUN chown -R coder:coder /var/lib/rstudio-server | |||
| RUN echo "server-pid-file=/tmp/rstudio-server.pid" >> /etc/rstudio/rserver.conf | |||
| RUN echo "server-data-dir=/tmp/rstudio" >> /etc/rstudio/rserver.conf | |||
| RUN echo "www-frame-origin=same" >> /etc/rstudio/rserver.conf | |||
There was a problem hiding this comment.
@khorne3 is there a way to add this to 1.23 as well?
There was a problem hiding this comment.
Yes, we can add this to any docs. It's valid even for older versions that do not need it
greyscaled
approved these changes
Oct 5, 2021
|
@vapurrmaid 1.23 is generated using |
khorne3
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This fixes the
X-FRAME-OPTIONSto be set tosame. This is required to fix rstudio in 1.23. Any previous versions, this has no effect.