Skip to content

chore: add 1.28.4 changelog #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2022
Merged

chore: add 1.28.4 changelog #909

merged 7 commits into from
Mar 18, 2022

Conversation

khorne3
Copy link
Contributor

@khorne3 khorne3 commented Mar 17, 2022

No description provided.

@khorne3 khorne3 requested a review from deansheather March 17, 2022 18:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022

✨ Coder.com for PR #909 deployed! It will be updated on every commit.

@deansheather deansheather requested a review from greyscaled March 17, 2022 20:08
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 12 to 15
- web: added hosting for the **Open in Coder SVGs** in Coder so that the
icons render properly in firewalled networks. Coder will continue to support
the existing external CDN for such icons, but the default will be the SVG
hosted by Coder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording for this seems confusing, how about:

web: the Open in Coder SVG is now served from your Coder deployment rather than our CDN so airgapped customers can use this feature. Existing button images will continue to be served from our CDN until updated.

@deansheather deansheather merged commit 5a9a721 into main Mar 18, 2022
@deansheather deansheather deleted the release-1.28.4 branch March 18, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants