chore: add docker group command #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #949 deployed! It will be updated on every commit.
|
|
This pull request has been linked to Shortcut Story #22848: chore: Update CVM Docker image docs to include docker group and docker-compose Dockerfile steps. |
khorne3
approved these changes
Apr 18, 2022
deansheather
approved these changes
Apr 18, 2022
Comment on lines
64
to
65
| RUN curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose | ||
| RUN chmod +x /usr/local/bin/docker-compose |
There was a problem hiding this comment.
these can be joined to reduce the amount of layers using \ &&
| RUN useradd coder \ | ||
| --create-home \ | ||
| --shell=/bin/bash \ | ||
| # Add user `coder` to the `docker` group |
There was a problem hiding this comment.
Does this work? I thought you couldn't put comments in the middle of a command in bash
There was a problem hiding this comment.
oh, not sure. i added that just to point it out. i can remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates our CVM image docs to include adding the
coderuser to thedockergroup.this is necessary for any non-root user to use Docker, as the Docker Engine is run as
root.[sc-22848]