feat: helm: support adding affinity rule for coderd service #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #17413: enterprise-helm: add anti-affinity option to coderd deployment. |
deansheather
approved these changes
Oct 21, 2021
jawnsy
reviewed
Oct 21, 2021
johnstcn
commented
Oct 22, 2021
| {{- else }} | ||
| {{- tpl (.value | toYaml) .context }} | ||
| {{- end }} | ||
| {{- end -}} |
There was a problem hiding this comment.
This is shamlessly lifted from Bitnami's charts repo :-)
jawnsy
approved these changes
Oct 22, 2021
|
@khorne3 I know we autogenerate some docs for Helm values, I'm not sure if we need to note this anywhere, like in the release notes? Should be compatible with prior versions due to new defaults |
|
Yeah, release notes would be good. I'll add a mention to 1.24 changelog |
|
Thanks @khorne3 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
coderd.affinityconfiguration knob. This allows the user to specify any affinity they like for thecoderddeployment. An example affinity is provided.