feat: Add support for AWS_STS_REGIONAL_ENDPOINTS #230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 25, 2022 09:56
Add the environment variable to the coder service as well
|
I have tested this on my local deployment the following :
|
|
@ericpaulsen do you want me to squash some commits ? |
ericpaulsen
approved these changes
Mar 25, 2022
|
Sorry about this taking so long, I'm going try to make a separate PR today that adds support for arbitrary env variables on coderd and I'll ping you for review :) |
Hello, if you are busy at the moment I do not mind implementing this feature. How I see it would require to modify this MR to allow for |
|
Thanks for this PR, I've made the env vars change in #236 which will land in 1.29.1 and 1.30.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS_STS_REGIONAL_ENDPOINTSvalue isregionalvalues.yaml:awsStsRegionalEndpoints.enable(false by default) which activates the environment variableAWS_STS_REGIONAL_ENDPOINTSI have not yet tested this on a coder deployment, I will remove the WIP once I can confirm it works as intended.