fix: devurlsHost ref in ingress template #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Mar 19, 2022
coadler
approved these changes
Mar 19, 2022
|
Thank you for your contribution! @stevek-pro |
|
@deansheather do you have a timeline when this fix will be added to v1.29.1 or v1.29.x ? Dev URLs are not usable without it and we would really welcome it. |
|
@lanzrein we plan on doing 1.29.2 tomorrow which will include it, and failing that it will be released in 1.30 RC1 next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingress template was not working correctly because there is neither a
.Values.devurlsnor a.Values.devurls.host. Correct values is in both cases.Values.coderd.devurlsHost.