Skip to content

fix: Update API versions of deprecated templates #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Update API versions of deprecated templates #86

wants to merge 1 commit into from

Conversation

kylecarbs
Copy link
Member

During our deployment we had a few warnings of deprecation:

image

@kylecarbs kylecarbs requested review from jawnsy and deansheather May 20, 2021 05:10
@deansheather deansheather requested a review from coadler May 20, 2021 05:56
deansheather
deansheather reviewed May 20, 2021
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anything else need to be changed? It's kinda weird that nothing changes in our templates and we just have to change the version number.

We also need to make sure customers support these new versions first

@jawnsy
Copy link
Contributor

jawnsy commented May 20, 2021

Yeah, the reason we haven't fixed these deprecated APIs is because we don't have a defined minimum Kubernetes support level, and we need to do some research to figure out what versions we need to support based on our customers. There was a card for this: https://app.clubhouse.io/coder/story/7570/switch-away-from-alpha-beta-api-versions-if-possible and I also started updating the docs (we currently say that we support 1.13 or later), but I think we need to do some research to figure out what our baseline version should be: coder/docs#232

We also use some of these APIs in our code (try.sh, some of our client-go code), so those can be cleaned up as well

@kylecarbs
Copy link
Member Author

kylecarbs commented May 22, 2021 •
edited
Loading

Makes sense.

We'll be out of date with the latest Kube on August 4th if we don't make these changes by then.

See: https://www.kubernetes.dev/resources/release/#tldr

@jawnsy
Copy link
Contributor

jawnsy commented Jun 16, 2021

Superseded by #106

@jawnsy jawnsy closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather left review comments

@jawnsy jawnsy Awaiting requested review from jawnsy

@coadler coadler Awaiting requested review from coadler

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @jawnsy @deansheather