Skip to content

fix(log): increase coder rpcConnectTimeout to 30s #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024
+53 −1
Merged

fix(log): increase coder rpcConnectTimeout to 30s #313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6aaae8
chore(log): add unit test to validate that retries happen
johnstcn Aug 12, 2024
7d72b56
fix(log): bump rpcConnectTimeout to 30s
johnstcn Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(log): bump rpcConnectTimeout to 30s
  • Loading branch information
@johnstcn
johnstcn committed Aug 12, 2024
commit 7d72b567bdd82a458eb73d044c51d5edb557b51b
5 changes: 4 additions & 1 deletion log/coder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ import (
)

var (
rpcConnectTimeout = 10 * time.Second
// We set a relatively high connection timeout for the initial connection.
// There is an unfortunate race between the envbuilder container starting and the
// associated provisioner job completing.
rpcConnectTimeout = 30 * time.Second
logSendGracePeriod = 10 * time.Second
minAgentAPIV2 = "v2.9"
)
Expand Down