fix(log): properly set logrus level #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Aug 27, 2024
log/hijack/logrus.go
Outdated
| @@ -0,0 +1,62 @@ | |||
| package hijack | |||
There was a problem hiding this comment.
How about logrushijack? I feel this package name is a bit too generic. 🤔
There was a problem hiding this comment.
I don't mind renaming, but logrushijack is kinda hard to read IMO.
There was a problem hiding this comment.
I think that's fine for a one-off package that isn't used much elsewhere, logjack is my alternative suggestion. 😄
(Or just move into log package.)
There was a problem hiding this comment.
:D I like logjack but probably simplest to move it into log.
johnstcn
added a commit
that referenced
this pull request
Aug 27, 2024
(cherry picked from commit 8b9ec59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HijackLogrusto packagelog.HijackLogrus.Cherry-pick to
release/1.0branch.