-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add enterprise wrapper and image + ci #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,32 @@ | |||
module github.com/coder/exectrace/enterprise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be a separate module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid imports from the enterprise module being added to the go.mod of any external packages that use only the parent package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with this code but it LGTM
enterprise
dir containing a wrapper binary functionally equivalent to exectrace in v1. This dir is licensed under the enterprise license.Closes coder/coder#8839
Closes coder/coder#5314