Skip to content

Add image-specific READMEs with dockerhub badges #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2020
Merged

Add image-specific READMEs with dockerhub badges #28

merged 1 commit into from
Dec 2, 2020

Conversation

greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Oct 26, 2020 •
edited
Loading

Summary

Adds a README containing a badge for each of our images. The badge content is the number of dockerhub pulls, and the link is to the image's home on dockerhub.

@greyscaled greyscaled added the docs Improvements or additions to documentation label Oct 26, 2020
@greyscaled greyscaled self-assigned this Oct 26, 2020
wbobeirne
wbobeirne reviewed Oct 26, 2020
View reviewed changes
Copy link

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. I was considering having us add a README for each image to explain what it offers, might make a bit more sense to have each of those contain their own badge so that it's a bit less noisy.

@greyscaled greyscaled removed the request for review from GirlBossRush November 14, 2020 19:47
@greyscaled

This comment has been minimized.

Sign in to view
jawnsy
jawnsy reviewed Nov 28, 2020
View reviewed changes
@greyscaled greyscaled changed the title Add dockerhub badges to readme Add image-specific READMEs with dockerhub badges Dec 1, 2020
@greyscaled greyscaled merged commit 99aba5c into master Dec 2, 2020
@greyscaled greyscaled deleted the vapurrmaid/badges branch December 2, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawnsy jawnsy jawnsy left review comments

@wbobeirne wbobeirne wbobeirne left review comments

Assignees

@greyscaled greyscaled

Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greyscaled @jawnsy @wbobeirne