Skip to content

test flake: TestSSH/StartStoppedWorkspaceConflict #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Jan 8, 2025 · 1 comment · Fixed by coder/coder#16082
Closed

test flake: TestSSH/StartStoppedWorkspaceConflict #269

johnstcn opened this issue Jan 8, 2025 · 1 comment · Fixed by coder/coder#16082
Assignees
@mafredri
Labels
flake

Comments

@johnstcn
Copy link
Member

johnstcn commented Jan 8, 2025 •
edited
Loading

Seen here (windows test-postgres): https://github.com/coder/coder/actions/runs/12676111432/job/35328614075?pr=16072

    ssh_test.go:228: 
        	Error Trace:	C:/a/coder/coder/cli/ssh_test.go:228
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 1
        	Test:       	TestSSH/StartStoppedWorkspaceConflict
        	Messages:   	expected 2 conflicts

cc @mafredri
@johnstcn johnstcn added the flake label Jan 8, 2025
@johnstcn johnstcn mentioned this issue Jan 8, 2025
Merged
@mafredri
Copy link
Member

mafredri commented Jan 9, 2025

Oh that's fun. On Windows the processing is so slow that the build has time to complete and a second is successfully started and completed 😅, hence no conflict. I'll improve the synchronization to avoid the issue.

mafredri added a commit to coder/coder that referenced this issue Jan 9, 2025
@mafredri
test(cli/ssh): sync post-build to fix build race on slow runners
d3d0410 
Fixes coder/internal#269
@mafredri mafredri mentioned this issue Jan 9, 2025
Merged
@bcpeinhardt bcpeinhardt mentioned this issue Jan 10, 2025
Merged
@mafredri mafredri mentioned this issue Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(cli/ssh): fix ssh start conflict test by faking API response coder/coder
2 participants
@mafredri @johnstcn