Skip to content

test(cli/ssh): fix ssh start conflict test by faking API response #16082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 10, 2025
Merged

test(cli/ssh): fix ssh start conflict test by faking API response #16082

merged 3 commits into from
Jan 10, 2025

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jan 9, 2025 •
edited
Loading

test(cli/ssh): sync post-build to fix build race on slow runners

Fixes coder/internal#269
Fixes #16089

@mafredri mafredri requested a review from johnstcn January 9, 2025 09:19
@mafredri mafredri force-pushed the mafredri/fix-internal-269 branch from 3954f5b to 979951e Compare January 9, 2025 09:52
@mafredri mafredri mentioned this pull request Jan 10, 2025
Closed
@mafredri mafredri requested a review from dannykopping January 10, 2025 12:14
@mafredri mafredri enabled auto-merge (squash) January 10, 2025 12:27
@mafredri mafredri changed the title test(cli/ssh): sync post-build to fix build race on slow runners test(cli/ssh): fix ssh start conflict test by faking API response Jan 10, 2025
johnstcn
johnstcn approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp 👍

@mafredri mafredri merged commit 8c44cd3 into main Jan 10, 2025
33 checks passed
@mafredri mafredri deleted the mafredri/fix-internal-269 branch January 10, 2025 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@dannykopping dannykopping Awaiting requested review from dannykopping

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: TestSSH/StartStoppedWorkspaceConflict test flake: TestSSH/StartStoppedWorkspaceConflict
2 participants
@mafredri @johnstcn