Skip to content

Implement REST API to pause/resume sending notifications, with CLI #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dannykopping opened this issue Jul 4, 2024 · 2 comments · Fixed by coder/coder#13873
Closed

Implement REST API to pause/resume sending notifications, with CLI #4

dannykopping opened this issue Jul 4, 2024 · 2 comments · Fixed by coder/coder#13873
Assignees
@mtojek
Labels
project/notifications

Comments

@dannykopping
Copy link
Collaborator

Relates to coder/coder#13331

Users may encounter a problem with, for example, their SMTP server and instead of having all the notifications exhaust their retries while the SMTP server is under maintenance - rather pause all notification dispatches during this time.

All this has to do is prevent the notifiers from executing their dispatch loop.

We should implement a CLI action to call this API.
@mtojek
Copy link
Member

mtojek commented Jul 5, 2024

rather pause all notification dispatches during this time.

@dannykopping I assume this is a manual "circuit breaker". When disabled, should notifications still be queued in the database? Only dispatcher part should be off?

@dannykopping
Copy link
Collaborator Author

That sounds good to me 👍

This was referenced Jul 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
project/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): pause notifications coder/coder
2 participants
@dannykopping @mtojek