Skip to content

flake: TestGetProvisionerJobsByIDsWithQueuePosition #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ethanndickson opened this issue Mar 4, 2025 · 3 comments
Closed

flake: TestGetProvisionerJobsByIDsWithQueuePosition #451

ethanndickson opened this issue Mar 4, 2025 · 3 comments
Assignees
@evgeniy-scherbina

Comments

@ethanndickson
Copy link
Member

ethanndickson commented Mar 4, 2025 •
edited
Loading

Spotted in nightly-gauntlet
https://github.com/coder/coder/actions/runs/13645971060/job/38144852381

Bunch of test cases timing out, here's just one:

=== Failed
=== FAIL: coderd/database TestGetProvisionerJobsByIDsWithQueuePosition/test-case-5 (1.76s)
    t.go:106: 2025-03-04 04:07:35.133 [debu]  pubsub: pubsub dialing postgres  network=tcp  address=127.0.0.1:5432  timeout_ms=0
    t.go:106: 2025-03-04 04:07:35.134 [debu]  pubsub: pubsub postgres TCP connection established  network=tcp  address=127.0.0.1:5432  timeout_ms=0  elapsed_ms=0
    t.go:106: 2025-03-04 04:07:35.172 [debu]  pubsub: pubsub connected to postgres
    t.go:106: 2025-03-04 04:07:35.172 [debu]  pubsub: pubsub has started
    querier_test.go:2442: 
        	Error Trace:	/Users/runner/work/coder/coder/coderd/database/querier_test.go:2442
        	Error:      	Received unexpected error:
        	            	context deadline exceeded
        	Test:       	TestGetProvisionerJobsByIDsWithQueuePosition/test-case-5
    t.go:106: 2025-03-04 04:07:35.286 [info]  pubsub: pubsub is closing
    t.go:106: 2025-03-04 04:07:35.286 [info]  pubsub: pubsub listen stopped receiving notify
    t.go:106: 2025-03-04 04:07:35.286 [debu]  pubsub: pubsub closed
    --- FAIL: TestGetProvisionerJobsByIDsWithQueuePosition/test-case-5 (1.76s)

Looks like these tests are brand new, introduced in: coder/coder#16685
@ethanndickson
Copy link
Member Author

ethanndickson commented Mar 4, 2025 •
edited
Loading

For context, the nightly-gauntlet runs tests against Postgres on mac & windows, regular CI doesn't.

@ethanndickson
Copy link
Member Author

Also spotted on main, Ubuntu + PG https://github.com/coder/coder/actions/runs/13646577562/job/38146519157

@evgeniy-scherbina evgeniy-scherbina mentioned this issue Mar 4, 2025
Merged
evgeniy-scherbina added a commit to coder/coder that referenced this issue Mar 4, 2025
@evgeniy-scherbina
test: fix flaky tests (#16799)
84881a0 
Relates to: coder/internal#451

Create separate context with timeout for every subtest.
@ethanndickson
Copy link
Member Author

ethanndickson commented Mar 5, 2025 •
edited
Loading

Closed by coder/coder#16799

Relevant blog post: https://coder.com/blog/go-testing-contexts-and-t-parallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgeniy-scherbina evgeniy-scherbina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evgeniy-scherbina @ethanndickson