Skip to content

flake: TestSSH_Container #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Mar 25, 2025 · 2 comments · Fixed by coder/coder#17148
Closed

flake: TestSSH_Container #524

spikecurtis opened this issue Mar 25, 2025 · 2 comments · Fixed by coder/coder#17148
Assignees
@johnstcn
Labels
flake

Comments

@spikecurtis
Copy link

Flaked in a Coder on Coder workspace. Logs attached.

    ptytest.go:167: 2025-03-25 10:26:58.141: cmd: read error: match deadline exceeded: context deadline exceeded (wanted "No containers found!"; got "")
    ptytest.go:167:
                Error Trace:    /home/coder/repos/coder/pty/ptytest/ptytest.go:374
                                                        /home/coder/repos/coder/pty/ptytest/ptytest.go:198
                                                        /home/coder/repos/coder/pty/ptytest/ptytest.go:167
                                                        /home/coder/repos/coder/pty/ptytest/ptytest.go:162
                                                        /home/coder/repos/coder/pty/ptytest/ptytest.go:149
                                                        /home/coder/repos/coder/cli/ssh_test.go:2041
                Error:          read error
                Test:           TestSSH_Container/NotEnabled
                Messages:       match deadline exceeded: context deadline exceeded (wanted "No containers found!"; got "")

TestSSH_Container-flake-failure.txt
@johnstcn
Copy link
Member

This suggests to me that we timed out dialing the agent:

    t.go:106: 2025-03-25 10:26:52.438 [warn]  coderd: GET  host=localhost:40409  path=/api/v2/workspaceagents/0726263a-f555-43e1-aafd-c9e8c23fa420/containers  proto=HTTP/1.1  remote_addr=127.0.0.1  start="2025-03-25T10:26:43.397412386Z"  took=9.04125551s  status_code=500  latency_ms=9041  request_id=a269a73c-66d9-4d99-aec6-36b27c45577c ...
        response_body= {
                        "message": "Internal error dialing workspace agent.",
                        "detail": "agent is unreachable"
                       }

The only solution I can see to that is increasing the test timeout.

@johnstcn johnstcn mentioned this issue Mar 28, 2025
Merged
@johnstcn johnstcn reopened this Apr 14, 2025
@johnstcn
Copy link
Member

johnstcn commented Apr 14, 2025 •
edited
Loading

Seen again here: https://github.com/coder/coder/actions/runs/14409252264/job/40413136383?pr=17364

        	Error Trace:	/home/runner/work/coder/coder/pty/ptytest/ptytest.go:372
        	            				/home/runner/work/coder/coder/pty/ptytest/ptytest.go:196
        	            				/home/runner/work/coder/coder/pty/ptytest/ptytest.go:167
        	            				/home/runner/work/coder/coder/pty/ptytest/ptytest.go:162
        	            				/home/runner/work/coder/coder/pty/ptytest/ptytest.go:149
        	            				/home/runner/work/coder/coder/cli/ssh_test.go:2045
        	Error:      	read error
        	Test:       	TestSSH_Container/OK
        	Messages:   	match deadline exceeded: context deadline exceeded (wanted " #"; got "")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(cli): increase timeout for TestSSH_Container subtests coder/coder
2 participants
@johnstcn @spikecurtis