Skip to content

flake: data race in echo provisioner #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sreya opened this issue Mar 27, 2025 · 0 comments · Fixed by coder/coder#17142
Closed

flake: data race in echo provisioner #546

sreya opened this issue Mar 27, 2025 · 0 comments · Fixed by coder/coder#17142
Assignees
@aslilac

Comments

@sreya
Copy link

sreya commented Mar 27, 2025

Seen here on this run

2025-03-27T15:09:07.2360936Z ==================
2025-03-27T15:09:07.2361018Z WARNING: DATA RACE
2025-03-27T15:09:07.2361189Z Read at 0x00c012475328 by goroutine 23254:
2025-03-27T15:09:07.2361441Z   github.com/coder/coder/v2/provisioner/echo.TarWithOptions()
2025-03-27T15:09:07.2361751Z       /home/runner/work/coder/coder/provisioner/echo/serve.go:257 +0x1147
2025-03-27T15:09:07.2365669Z   github.com/coder/coder/v2/coderd/coderdtest.CreateTemplateVersion()
2025-03-27T15:09:07.2365983Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:875 +0xee
2025-03-27T15:09:07.2366172Z   github.com/coder/coder/v2/cli_test.TestRestart.func4()
2025-03-27T15:09:07.2366453Z       /home/runner/work/coder/coder/cli/restart_test.go:177 +0x28a
2025-03-27T15:09:07.2366583Z   github.com/coder/coder/v2/coderd.New()
2025-03-27T15:09:07.2366839Z       /home/runner/work/coder/coder/coderd/coderd.go:485 +0x392c
2025-03-27T15:09:07.2366965Z   github.com/coder/coder/v2/coderd.New()
2025-03-27T15:09:07.2367230Z       /home/runner/work/coder/coder/coderd/coderd.go:474 +0x3516
2025-03-27T15:09:07.2367417Z   github.com/coder/coder/v2/coderd/coderdtest.NewWithAPI()
2025-03-27T15:09:07.2367735Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:581 +0xf1
2025-03-27T15:09:07.2367907Z   github.com/coder/coder/v2/coderd/coderdtest.NewOptions()
2025-03-27T15:09:07.2368218Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:287 +0x1368
2025-03-27T15:09:07.2368449Z   github.com/coder/coder/v2/coderd/coderdtest.NewOptions()
2025-03-27T15:09:07.2368790Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:281 +0x1247
2025-03-27T15:09:07.2368960Z   github.com/coder/coder/v2/coderd/coderdtest.NewWithAPI()
2025-03-27T15:09:07.2369271Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:579 +0xd7
2025-03-27T15:09:07.2369475Z   github.com/coder/coder/v2/coderd/coderdtest.newWithCloser()
2025-03-27T15:09:07.2369780Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:213 +0x3b
2025-03-27T15:09:07.2369947Z   github.com/coder/coder/v2/coderd/coderdtest.New()
2025-03-27T15:09:07.2370363Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:181 +0x27
2025-03-27T15:09:07.2370531Z   github.com/coder/coder/v2/cli_test.TestRestart.func4()
2025-03-27T15:09:07.2370796Z       /home/runner/work/coder/coder/cli/restart_test.go:174 +0xe8
2025-03-27T15:09:07.2370895Z   testing.tRunner()
2025-03-27T15:09:07.2371212Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-27T15:09:07.2371338Z   testing.(*T).Run.gowrap1()
2025-03-27T15:09:07.2371629Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-27T15:09:07.2371635Z 
2025-03-27T15:09:07.2371770Z Previous write at 0x00c012475328 by goroutine 23255:
2025-03-27T15:09:07.2371994Z   github.com/coder/coder/v2/provisioner/echo.TarWithOptions()
2025-03-27T15:09:07.2372252Z       /home/runner/work/coder/coder/provisioner/echo/serve.go:258 +0x11b0
2025-03-27T15:09:07.2372521Z   github.com/coder/coder/v2/coderd/coderdtest.CreateTemplateVersion()
2025-03-27T15:09:07.2372797Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:875 +0xee
2025-03-27T15:09:07.2372995Z   github.com/coder/coder/v2/cli_test.TestRestart.func5()
2025-03-27T15:09:07.2373230Z       /home/runner/work/coder/coder/cli/restart_test.go:231 +0x28a
2025-03-27T15:09:07.2373371Z   github.com/coder/coder/v2/coderd.New()
2025-03-27T15:09:07.2373623Z       /home/runner/work/coder/coder/coderd/coderd.go:485 +0x392c
2025-03-27T15:09:07.2373784Z   github.com/coder/coder/v2/coderd.New()
2025-03-27T15:09:07.2374007Z       /home/runner/work/coder/coder/coderd/coderd.go:474 +0x3516
2025-03-27T15:09:07.2374210Z   github.com/coder/coder/v2/coderd/coderdtest.NewWithAPI()
2025-03-27T15:09:07.2374484Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:581 +0xf1
2025-03-27T15:09:07.2374681Z   github.com/coder/coder/v2/coderd/coderdtest.NewOptions()
2025-03-27T15:09:07.2375002Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:287 +0x1368
2025-03-27T15:09:07.2375176Z   github.com/coder/coder/v2/coderd/coderdtest.NewOptions()
2025-03-27T15:09:07.2375554Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:281 +0x1247
2025-03-27T15:09:07.2375724Z   github.com/coder/coder/v2/coderd/coderdtest.NewWithAPI()
2025-03-27T15:09:07.2376049Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:579 +0xd7
2025-03-27T15:09:07.2376246Z   github.com/coder/coder/v2/coderd/coderdtest.newWithCloser()
2025-03-27T15:09:07.2376553Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:213 +0x3b
2025-03-27T15:09:07.2376705Z   github.com/coder/coder/v2/coderd/coderdtest.New()
2025-03-27T15:09:07.2377007Z       /home/runner/work/coder/coder/coderd/coderdtest/coderdtest.go:181 +0x27
2025-03-27T15:09:07.2377159Z   github.com/coder/coder/v2/cli_test.TestRestart.func5()
2025-03-27T15:09:07.2377459Z       /home/runner/work/coder/coder/cli/restart_test.go:228 +0xe8
2025-03-27T15:09:07.2377559Z   testing.tRunner()
2025-03-27T15:09:07.2377920Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-27T15:09:07.2378035Z   testing.(*T).Run.gowrap1()
2025-03-27T15:09:07.2378315Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-27T15:09:07.2378320Z 
2025-03-27T15:09:07.2378450Z Goroutine 23254 (running) created at:
2025-03-27T15:09:07.2378650Z   testing.(*T).Run()
2025-03-27T15:09:07.2378915Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x8f2
2025-03-27T15:09:07.2379099Z   github.com/coder/coder/v2/cli_test.TestRestart()
2025-03-27T15:09:07.2379331Z       /home/runner/work/coder/coder/cli/restart_test.go:171 +0x696
2025-03-27T15:09:07.2379470Z   testing.tRunner()
2025-03-27T15:09:07.2379731Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-27T15:09:07.2379867Z   testing.(*T).Run.gowrap1()
2025-03-27T15:09:07.2380212Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-27T15:09:07.2380216Z 
2025-03-27T15:09:07.2380349Z Goroutine 23255 (running) created at:
2025-03-27T15:09:07.2380443Z   testing.(*T).Run()
2025-03-27T15:09:07.2380766Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x8f2
2025-03-27T15:09:07.2380915Z   github.com/coder/coder/v2/cli_test.TestRestart()
2025-03-27T15:09:07.2381174Z       /home/runner/work/coder/coder/cli/restart_test.go:225 +0x716
2025-03-27T15:09:07.2381277Z   testing.tRunner()
2025-03-27T15:09:07.2381557Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1792 +0x225
2025-03-27T15:09:07.2381685Z   testing.(*T).Run.gowrap1()
2025-03-27T15:09:07.2381975Z       /opt/hostedtoolcache/go/1.24.1/x64/src/testing/testing.go:1851 +0x44
2025-03-27T15:09:07.2382058Z ==================
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix data race in echo provisioner coder/coder
2 participants
@aslilac @sreya