Skip to content

flake: TestAgent_ImmediateClose #604

Closed
coder/coder
#17630
@ethanndickson

Description

@ethanndickson

https://github.com/coder/coder/actions/runs/14771059990/job/41471072839

=== FAIL: agent TestAgent_ImmediateClose (5.01s)
[...]
==================
WARNING: DATA RACE
Write at 0x00c000255408 by goroutine 3544:
  github.com/coder/coder/v2/agent/agentscripts.(*Runner).Init()
      /home/runner/work/coder/coder/agent/agentscripts/agentscripts.go:161 +0x397
  github.com/coder/coder/v2/agent.(*agent).run.(*agent).handleManifest.func9()
      /home/runner/work/coder/coder/agent/agent.go:1135 +0x1af3
  github.com/coder/coder/v2/agent.(*apiConnRoutineManager).startAgentAPI.func1()
      /home/runner/work/coder/coder/agent/agent.go:2017 +0x145
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/runner/go/pkg/mod/golang.org/x/sync@v0.13.0/errgroup/errgroup.go:79 +0x91

Previous read at 0x00c000255408 by goroutine 37:
  github.com/coder/coder/v2/agent/agentscripts.(*Runner).Execute()
      /home/runner/work/coder/coder/agent/agentscripts/agentscripts.go:231 +0xb4
  github.com/coder/coder/v2/agent.(*agent).Close()
      /home/runner/work/coder/coder/agent/agent.go:1828 +0x5d2
  github.com/coder/coder/v2/agent_test.TestAgent_ImmediateClose()
      /home/runner/work/coder/coder/agent/agent_test.go:115 +0x10ac
  testing.tRunner()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:1792 +0x225
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:1851 +0x44

Goroutine 3544 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/runner/go/pkg/mod/golang.org/x/sync@v0.13.0/errgroup/errgroup.go:76 +0x124
  github.com/coder/coder/v2/agent.(*apiConnRoutineManager).startAgentAPI()
      /home/runner/work/coder/coder/agent/agent.go:2015 +0x4e4
    t.go:106: 2025-05-01 06:30:30.578 [debu]  agent: successfully reported lifecycle state  payload="lifecycle:{state:SHUTTING_DOWN changed_at:{seconds:1746081030 nanos:576744000}}"
  github.com/coder/coder/v2/agent.(*agent).run()
      /home/runner/work/coder/coder/agent/agent.go:1006 +0xbc4
  github.com/coder/coder/v2/agent.(*agent).runLoop()
      /home/runner/work/coder/coder/agent/agent.go:359 +0x1f1
  github.com/coder/coder/v2/agent.(*agent).init.gowrap1()
      /home/runner/work/coder/coder/agent/agent.go:346 +0x33

Goroutine 37 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:1851 +0x8f2
  testing.runTests.func1()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:2279 +0x85
  testing.tRunner()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:1792 +0x225
  testing.runTests()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:2277 +0x96c
  testing.(*M).Run()
      /opt/hostedtoolcache/go/1.24.2/x64/src/testing/testing.go:2142 +0xeea
  go.uber.org/goleak.VerifyTestMain()
      /home/runner/go/pkg/mod/go.uber.org/goleak@v1.3.1-0.20240429205332-517bace7cc29/testmain.go:53 +0x64
  github.com/coder/coder/v2/agent_test.TestMain()
      /home/runner/work/coder/coder/agent/agent_test.go:66 +0x1a4
  main.main()
      _testmain.go:153 +0x16d
==================

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions