Skip to content

Impl: test minimum supported Coder version #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2022
Merged

Impl: test minimum supported Coder version #118

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
059a9d5
chore: rename version property
fioan89 Dec 8, 2022
6ce1d6f
chore: increase max compatible Coder version to 0.13.1
fioan89 Dec 8, 2022
e3fec1c
Impl: parse the patch number from semver
fioan89 Dec 8, 2022
91ce551
impl: check if Coder version is in range
fioan89 Dec 9, 2022
566b8e5
chore: remove unused code
fioan89 Dec 9, 2022
1e77f43
impl: check if Coder version is in range
fioan89 Dec 9, 2022
cf20457
chore: remove unused code
fioan89 Dec 9, 2022
96feb73
Merge branch 'impl-test-min-support-for-coder' of github.com:coder/co…
fioan89 Dec 9, 2022
24b00be
impl: add UTs
fioan89 Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
impl: add UTs
  • Loading branch information
@fioan89
fioan89 committed Dec 9, 2022
commit 24b00beff2a360626aaf3df28718792742733a9e
131 changes: 127 additions & 4 deletions src/test/groovy/CoderSemVerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package com.coder.gateway.sdk

import spock.lang.Unroll

@Unroll
class CoderSemVerTest extends spock.lang.Specification {

def 'semver versions are valid'() {
def "#semver is valid"() {
expect:
CoderSemVer.isValidVersion(semver)

Expand Down Expand Up @@ -40,7 +43,7 @@ class CoderSemVerTest extends spock.lang.Specification {
'1.0.0-0A.is.legal']
}

def 'semver versions are parsed and correct major and minor values are extracted'() {
def "#semver version is parsed and correct major, minor and patch values are extracted"() {
expect:
CoderSemVer.parse(semver) == expectedCoderSemVer

Expand Down Expand Up @@ -79,7 +82,7 @@ class CoderSemVerTest extends spock.lang.Specification {
'1.0.0-0A.is.legal' || new CoderSemVer(1L, 0L, 0L)
}

def 'semver like versions that start with a `v` are considered valid'() {
def "#semver is considered valid even when it starts with `v`"() {
expect:
CoderSemVer.isValidVersion(semver)

Expand Down Expand Up @@ -117,7 +120,7 @@ class CoderSemVerTest extends spock.lang.Specification {
'v1.0.0-0A.is.legal']
}

def 'semver like versions that start with a `v` are parsed and correct major and minor values are extracted'() {
def "#semver is parsed and correct major, minor and patch values are extracted even though the version starts with a `v`"() {
expect:
CoderSemVer.parse(semver) == expectedCoderSemVer

Expand Down Expand Up @@ -155,4 +158,124 @@ class CoderSemVerTest extends spock.lang.Specification {
'v2147483647.2147483647.2147483647' || new CoderSemVer(2147483647L, 2147483647L, 2147483647L)
'v1.0.0-0A.is.legal' || new CoderSemVer(1L, 0L, 0L)
}

def "#firstVersion is > than #secondVersion"() {
expect:
firstVersion <=> secondVersion == 1

where:
firstVersion | secondVersion
new CoderSemVer(1, 0, 0) | new CoderSemVer(0, 0, 0)
new CoderSemVer(1, 0, 0) | new CoderSemVer(0, 0, 1)
new CoderSemVer(1, 0, 0) | new CoderSemVer(0, 1, 0)
new CoderSemVer(1, 0, 0) | new CoderSemVer(0, 1, 1)

new CoderSemVer(2, 0, 0) | new CoderSemVer(1, 0, 0)
new CoderSemVer(2, 0, 0) | new CoderSemVer(1, 3, 0)
new CoderSemVer(2, 0, 0) | new CoderSemVer(1, 0, 3)
new CoderSemVer(2, 0, 0) | new CoderSemVer(1, 3, 3)


new CoderSemVer(0, 1, 0) | new CoderSemVer(0, 0, 1)
new CoderSemVer(0, 2, 0) | new CoderSemVer(0, 1, 0)
new CoderSemVer(0, 2, 0) | new CoderSemVer(0, 1, 2)

new CoderSemVer(0, 0, 2) | new CoderSemVer(0, 0, 1)
}

def "#firstVersion is == #secondVersion"() {
expect:
firstVersion <=> secondVersion == 0

where:
firstVersion | secondVersion
new CoderSemVer(0, 0, 0) | new CoderSemVer(0, 0, 0)
new CoderSemVer(1, 0, 0) | new CoderSemVer(1, 0, 0)
new CoderSemVer(1, 1, 0) | new CoderSemVer(1, 1, 0)
new CoderSemVer(1, 1, 1) | new CoderSemVer(1, 1, 1)
new CoderSemVer(0, 1, 0) | new CoderSemVer(0, 1, 0)
new CoderSemVer(0, 1, 1) | new CoderSemVer(0, 1, 1)
new CoderSemVer(0, 0, 1) | new CoderSemVer(0, 0, 1)

}

def "#firstVersion is < than #secondVersion"() {
expect:
firstVersion <=> secondVersion == -1

where:
firstVersion | secondVersion
new CoderSemVer(0, 0, 0) | new CoderSemVer(1, 0, 0)
new CoderSemVer(0, 0, 1) | new CoderSemVer(1, 0, 0)
new CoderSemVer(0, 1, 0) | new CoderSemVer(1, 0, 0)
new CoderSemVer(0, 1, 1) | new CoderSemVer(1, 0, 0)

new CoderSemVer(1, 0, 0) | new CoderSemVer(2, 0, 0)
new CoderSemVer(1, 3, 0) | new CoderSemVer(2, 0, 0)
new CoderSemVer(1, 0, 3) | new CoderSemVer(2, 0, 0)
new CoderSemVer(1, 3, 3) | new CoderSemVer(2, 0, 0)


new CoderSemVer(0, 0, 1) | new CoderSemVer(0, 1, 0)
new CoderSemVer(0, 1, 0) | new CoderSemVer(0, 2, 0)
new CoderSemVer(0, 1, 2) | new CoderSemVer(0, 2, 0)

new CoderSemVer(0, 0, 1) | new CoderSemVer(0, 0, 2)
}

def 'in closed range comparison returns true when the version is equal to the left side of the range'() {
expect:
new CoderSemVer(1, 2, 3).isInClosedRange(new CoderSemVer(1, 2, 3), new CoderSemVer(7, 8, 9))
}

def 'in closed range comparison returns true when the version is equal to the right side of the range'() {
expect:
new CoderSemVer(7, 8, 9).isInClosedRange(new CoderSemVer(1, 2, 3), new CoderSemVer(7, 8, 9))
}

def "in closed range comparison returns false when #buildVersion is lower than the left side of the range"() {
expect:
buildVersion.isInClosedRange(new CoderSemVer(1, 2, 3), new CoderSemVer(7, 8, 9)) == false

where:
buildVersion << [
new CoderSemVer(0, 0, 0),
new CoderSemVer(0, 0, 1),
new CoderSemVer(0, 1, 0),
new CoderSemVer(1, 0, 0),
new CoderSemVer(0, 1, 1),
new CoderSemVer(1, 1, 1),
new CoderSemVer(1, 2, 1),
new CoderSemVer(0, 2, 3),
]
}

def "in closed range comparison returns false when #buildVersion is higher than the right side of the range"() {
expect:
buildVersion.isInClosedRange(new CoderSemVer(1, 2, 3), new CoderSemVer(7, 8, 9)) == false

where:
buildVersion << [
new CoderSemVer(7, 8, 10),
new CoderSemVer(7, 9, 0),
new CoderSemVer(8, 0, 0),
new CoderSemVer(8, 8, 9),
]
}

def "in closed range comparison returns true when #buildVersion is higher than the left side of the range but lower then the right side"() {
expect:
buildVersion.isInClosedRange(new CoderSemVer(1, 2, 3), new CoderSemVer(7, 8, 9)) == true

where:
buildVersion << [
new CoderSemVer(1, 2, 4),
new CoderSemVer(1, 3, 0),
new CoderSemVer(2, 0, 0),
new CoderSemVer(7, 8, 8),
new CoderSemVer(7, 7, 10),
new CoderSemVer(6, 9, 10),

]
}
}