Support for Gateway 2023 #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- there were a couple of API incompatibilities especially around remote path validation which now expects a more complex parameter. Fortunately there is an already existing helper hiding all that, that is also compatible with 2022.3 - some deprecated horizontal alignment parameters are now removed in GW 2023. Replaced them with the recommendations.
- removed usages for some internal and deprecated APIs - there are still a couple of usages remaining for which I could not find an equivalent. Especially stuff around creating the remote deployer.
- introduces support for Gateway 2023
- next button was filling the entire space without leaving some padding on the right of the window
code-asher
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some API changes that I could get rid of, for now. That means the support for GW 2023 can be added in the same release version that supports GW 2022.3.
Among other things a few deprecated API's were removed in the new version so I had to adapt the code. To reduce the risk of hitting similar issues in the future I tried as much as possible to get rid of all deprecated usages. Unfortunately there are a couple of them related to the creation of the so called "host deployer" for which I could not find suitable replacements. Spent some time decompiling the GW SDK with no luck. I'll ask the Jetbrains team for guidance.
Fixed some padding issues for the back/next buttons.