Allow customizing CLI locations #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df97a0b to
56743d0
Compare
Also change destinationDir to allow a null to make it easier to pass in a setting that could be unset.
Otherwise they will not be visible to the user. This is particularly important as it will probably be easy for a user to make a typo when overriding the binary URL and hit something that gives a 200 but is not actually the binary.
Since you cannot interact with the list without a CLI (and there is now a higher chance something can go wrong since the user can customize the source and destination) we should avoid showing them until the CLI is good to go.
Getting a test failure on macOS and just want to make sure it does download the first time.
56743d0 to
36500b5
Compare
c0021ca to
02fb84e
Compare
02fb84e to
cdc569a
Compare
johnstcn
reviewed
Apr 24, 2023
johnstcn
approved these changes
Apr 24, 2023
8397571 to
6f0024b
Compare
6f0024b to
aa54370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for customers that want to pull the binary from places like Artifactory or need to store it in certain places to work around system policies.
Windows seems to be failing in CI, looks like issues downloading dependencies? Will try again tomorrow after doing a bit more manual testing as well.