Skip to content

Check the agent's status #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2023
Merged

Check the agent's status #232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed37ab0
Simplify workspace status check
code-asher Apr 25, 2023
3b06d9f
Simplify agent model list
code-asher Apr 25, 2023
9b787c7
Add lifecycle_state and login_before_ready to agent response
code-asher Apr 25, 2023
9ab8769
Check agent status
code-asher Apr 25, 2023
5f31f55
Remove unused expressions
code-asher Apr 25, 2023
176d868
Add tooltips to describe the status
code-asher Apr 25, 2023
d5abf2b
Simplify some borders
code-asher Apr 25, 2023
596934c
Fix start/shutdown timeout status
code-asher Apr 26, 2023
a70a32b
Extract ready logic to WorkspaceAndAgentStatus
code-asher Apr 26, 2023
55e4a61
Change agent timeout description
code-asher Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extract ready logic to WorkspaceAndAgentStatus
  • Loading branch information
@code-asher
code-asher committed Apr 26, 2023
commit a70a32bf0a4f299186c7c78190094ffd488b13d6
8 changes: 8 additions & 0 deletions src/main/kotlin/com/coder/gateway/models/WorkspaceAndAgentStatus.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ enum class WorkspaceAndAgentStatus(val label: String, val description: String) {
else -> if (JBColor.isBright()) JBColor.LIGHT_GRAY else JBColor.DARK_GRAY
}

/**
* Return true if the agent is in a connectable state.
*/
fun ready(): Boolean {
return listOf(READY, START_ERROR, AGENT_STARTING_READY, START_TIMEOUT_READY)
.contains(this)
}

// We want to check that the workspace is `running`, the agent is
// `connected`, and the agent lifecycle state is `ready` to ensure the best
// possible scenario for attempting a connection.
Expand Down
10 changes: 2 additions & 8 deletions src/main/kotlin/com/coder/gateway/views/steps/CoderWorkspacesStepView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,8 @@ class CoderWorkspacesStepView(val setNextButtonEnabled: (Boolean) -> Unit) : Cod
setEmptyState("Disconnected")
setSelectionMode(ListSelectionModel.SINGLE_SELECTION)
selectionModel.addListSelectionListener {
val ready = listOf(
WorkspaceAndAgentStatus.READY,
WorkspaceAndAgentStatus.START_ERROR,
WorkspaceAndAgentStatus.AGENT_STARTING_READY,
WorkspaceAndAgentStatus.START_TIMEOUT_READY,
).contains(selectedObject?.agentStatus)
setNextButtonEnabled(ready && selectedObject?.agentOS == OS.LINUX)
if (ready && selectedObject?.agentOS != OS.LINUX) {
setNextButtonEnabled(selectedObject?.agentStatus?.ready() == true && selectedObject?.agentOS == OS.LINUX)
if (selectedObject?.agentStatus?.ready() == true && selectedObject?.agentOS != OS.LINUX) {
notificationBanner.apply {
component.isVisible = true
showInfo(CoderGatewayBundle.message("gateway.connector.view.coder.workspaces.unsupported.os.info"))
Expand Down