Retry listing editors #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to write a unit test for the selection logic.
When a workspace starts the workspace row is replaced with a row for the agent(s) and you have to select it again which is annoying (similarly for when the workspace stops). This preserves the selection when the workspace transitions.
Also my IDE tells me `is TimeoutCancellationException` is unreachable so I removed it.
c2dec2c to
6f51bcb
Compare
6f51bcb to
fa7c383
Compare
johnstcn
reviewed
Apr 27, 2023
| retrieveIDEs(executor, selectedWorkspace) | ||
| } catch (e: Exception) { | ||
| when(e) { | ||
| is InterruptedException -> Unit |
There was a problem hiding this comment.
For posterity: Unit is equivalent to void (see: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/)
johnstcn
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been testing manually by replacing
ddin my workspace with a script containingsleep infinity.I put the error underneath the field and added a retry with exponential backoff.
There is sometimes a visual stutter, I think replacing the combox renderer is being wacky but I am not sure if there is another way to do this. Or maybe it is the comment component being weird.