Downgrade platformVersion #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you run the latest plugin on Gateway 231 you get an error about DeployWithDownload being void when the IDE is not already installed. Reverting the platform version back to 231 makes the plugin work on both 231 and 232 (the current EAP). Honestly I do not understand why this is necessary as the API here does not appear to have changed at all. Upon doing some research though it appears that the platform version should match the "since build" version so I downgraded further. It seems `minimumWidth` and `maximumWidth` are not available in that version so our plugin is currently broken there as well. This is fixed by using `size` instead. I think normally the plugin verifier would catch these things and I tried getting it working by specifying the versions to check but it seems to be bugged; the only errors it shows appear to be from a failure to properly resolve dependencies.
|
I tested the plugin built by CI on 2022.3, 2023.1, and 2023.2 and with an existing IDE and with downloading a new IDE and all seems well. |
johnstcn
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run the latest plugin on Gateway 231 you get an error about DeployWithDownload being void when the IDE is not already installed.
Reverting the platform version back to 231 makes the plugin work on both 231 and 232 (the current EAP).
Honestly I do not understand why this is necessary as the API here does not appear to have changed at all.
Upon doing some research though it appears that the platform version should match the "since build" version so I downgraded further. It seems
minimumWidthandmaximumWidthare not available in that version so our plugin is currently broken there as well. This is fixed by usingsizeinstead.I think normally the plugin verifier would catch these things and I tried getting it working by specifying the versions to check but it seems to be bugged; the only errors it shows appear to be from a failure to properly resolve dependencies.