Skip to content

Remove HostName from SSH config #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

Remove HostName from SSH config #336

merged 1 commit into from
Dec 7, 2023

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Dec 7, 2023 •
edited
Loading

Having HostName causes errors in Gateway about the host not being found even though it seems to work in the end...but all those (many, many) errors make the logs noisy and maybe this is causing some instability in some cases.

I have no idea why Gateway is trying to connect to HostName when there is a ProxyCommand but it smells like a bug.

For now I removed HostName and there are no more errors. It was just copied from how the Coder CLI does things so hopefully it is not actually required somehow because I have no idea why it was included in the first place. Everything works for me without it.

@code-asher
Remove HostName from SSH config
9d7b2f1 
It is not necessary because the proxy command is what is in control here
and having HostName causes errors in Gateway about the host not being
found even though it seems to work in the end.
@code-asher code-asher force-pushed the asher/remove-hostname branch from abe05dd to 9d7b2f1 Compare December 7, 2023 03:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Qodana Community for JVM

54 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 29
Unstable API Usage 🔶 Warning 8
Incorrect string capitalization 🔶 Warning 7
Call to 'equals()' or 'hashCode()' on 'URL' object 🔶 Warning 2
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 1
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9 🔶 Warning 1
Redundant semicolon 🔶 Warning 1
Useless call on not-null type 🔶 Warning 1
Function naming convention ◽️ Notice 1
Class member can have 'private' visibility ◽️ Notice 1
Size check can be replaced with 'isNotEmpty()' ◽️ Notice 1
Trailing comma recommendations ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@code-asher code-asher requested a review from johnstcn December 7, 2023 03:59
@code-asher code-asher merged commit 71086c9 into main Dec 7, 2023
@code-asher code-asher deleted the asher/remove-hostname branch December 7, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @johnstcn