Skip to content

Bring parity with cli to header command #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

Bring parity with cli to header command #405

merged 1 commit into from
Apr 23, 2024
+45 −24

Conversation

code-asher
Copy link
Member

  • Do not include stderr.
  • Allow no output.

Closes #404

@code-asher code-asher force-pushed the asher/header-command-fix branch 2 times, most recently from 8599946 to a369a22 Compare April 23, 2024 17:36
@code-asher
Bring parity with cli to header command
649cdff 
- Do not include stderr.
- Allow no output.
@code-asher code-asher force-pushed the asher/header-command-fix branch from a369a22 to 649cdff Compare April 23, 2024 18:59
@code-asher code-asher marked this pull request as ready for review April 23, 2024 19:01
@github-actions GitHub Actions
Copy link
Contributor

Qodana Community for JVM

8 new problems were found

Inspection name Severity Problems
Incorrect string capitalization 🔶 Warning 6
Redundant semicolon 🔶 Warning 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.0
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@code-asher code-asher merged commit 3dfdd92 into main Apr 23, 2024
@code-asher code-asher deleted the asher/header-command-fix branch April 23, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not error when header command outputs nothing and ignore stderr
1 participant
@code-asher