Skip to content

chore: use background hostname for admin tasks #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 25, 2024
Merged

chore: use background hostname for admin tasks #446

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ddc22bf
chore: use background hostname for admin tasks
f0ssel Jun 24, 2024
3ee1a22
remove space
f0ssel Jun 24, 2024
4155b13
try test fix
f0ssel Jun 24, 2024
44856b4
try test fix
f0ssel Jun 24, 2024
405a485
try test fix
f0ssel Jun 24, 2024
75c825d
rebase
f0ssel Jun 25, 2024
6ff0681
use background on ssh command exec
f0ssel Jun 25, 2024
e6e77c2
remove env
f0ssel Jun 25, 2024
54232b7
fix newline
f0ssel Jun 25, 2024
cf673a1
disable on bg hostname
f0ssel Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use background on ssh command exec
  • Loading branch information
@f0ssel
f0ssel committed Jun 25, 2024
commit 6ff068145433518313148ace6945c5d0458b474c
2 changes: 1 addition & 1 deletion src/main/kotlin/com/coder/gateway/CoderRemoteConnectionHandle.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ class CoderRemoteConnectionHandle {
private fun exec(workspace: WorkspaceProjectIDE, command: String): String {
logger.info("Running command `$command` in ${workspace.hostname}:${workspace.idePathOnHost}/bin...")
return ProcessExecutor()
.command("ssh", "-t", workspace.hostname, "cd '${workspace.idePathOnHost}' ; cd bin ; $command")
.command("ssh", "-t", CoderCLIManager.getBackgroundHostName(workspace.hostname), "cd '${workspace.idePathOnHost}' ; cd bin ; $command")
.exitValues(0)
.readOutput(true)
.execute()
Expand Down