Skip to content

[DO NOT MERGE] Toolbox refactor #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Toolbox refactor #478

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
14a5651
Refactor for Toolbox
code-asher Sep 5, 2024
9f591ac
No naked booleans
code-asher Sep 12, 2024
8c34c64
Note cache directory
code-asher Sep 13, 2024
d6f9709
Get kotlin-language-server working
code-asher Sep 13, 2024
00d7321
Implement custom environment state
code-asher Sep 13, 2024
59e0bd6
Mark queued and starting as pending
code-asher Sep 16, 2024
1d83f50
Fix environment status not updating
code-asher Sep 16, 2024
3b73f10
Add todo for spinner icon
code-asher Sep 16, 2024
dd50651
Fix not updating ssh on the first run
code-asher Sep 18, 2024
c0db226
[toolbox] Build in CI (#487)
code-asher Sep 24, 2024
547fdea
[toolbox] Add workspace actions (#486)
code-asher Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix not updating ssh on the first run
  • Loading branch information
@code-asher
code-asher committed Sep 18, 2024
commit dd50651b629ce5e8f41681aca61428801bbf67a2
6 changes: 4 additions & 2 deletions src/main/kotlin/com/coder/gateway/CoderRemoteProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ class CoderRemoteProvider(

// Reconfigure if a new environment is found.
// TODO@JB: Should we use the add/remove listeners instead?
val newEnvironments = lastEnvironments?.let { environments.subtract(it) }
if (newEnvironments?.isNotEmpty() == true) {
val newEnvironments = lastEnvironments
?.let { environments.subtract(it) }
?: environments
if (newEnvironments.isNotEmpty()) {
logger.info("Found new environment(s), reconfiguring CLI: {}", newEnvironments)
cli.configSsh(newEnvironments.map { it.name }.toSet())
}
Expand Down