Skip to content

fix: skip installed EAP, RC, NIGHTLY and PREVIEW ides from showing if they are superseded #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Apr 29, 2025

The IDE and Project view will no longer show IDEs that are installed and which are not yet released, but
they have a released version available for download.

Old released IDEs that are installed should not be affected by the list of newer releases.

fioan89 added 2 commits April 30, 2025 01:10
The existing EAP snapshot was removed from the repo
… they are superseded

The IDE and Project view will no longer show IDEs that are installed and which are not yet released, but
they have a released version available for download.
@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 29, 2025

I'll follow tomorrow with some UTs.

Copy link
Contributor

github-actions bot commented Apr 29, 2025

Qodana Community for JVM

8 new problems were found

Inspection name Severity Problems
Local 'var' is never modified and can be declared as 'val' 🔶 Warning 1
Incorrect string capitalization 🔶 Warning 1
Redundant nullable return type 🔶 Warning 1
String concatenation that can be converted to string template ◽️ Notice 2
Argument could be converted to 'Set' to improve performance ◽️ Notice 1
Class member can have 'private' visibility ◽️ Notice 1
Redundant lambda arrow ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.2
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@matifali matifali requested a review from f0ssel April 30, 2025 01:46
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@fioan89
Copy link
Collaborator Author

fioan89 commented Apr 30, 2025

UTs were added to cover the new logic.

@fioan89 fioan89 requested a review from code-asher April 30, 2025 21:15
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@fioan89 fioan89 marked this pull request as ready for review May 1, 2025 17:54
@fioan89 fioan89 merged commit 79118e3 into main May 1, 2025
6 checks passed
@fioan89 fioan89 deleted the dont-show-installed-eaps-if-released-version-is-available branch May 1, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants