Skip to content

Refactor image extraction progress to use option #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor image extraction progress to use option #13

wants to merge 2 commits into from

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented May 30, 2024 •
edited
Loading

I made a branch with plan to upstream this (https://github.com/mafredri/kaniko/tree/mafredri/feat-add-image-fs-extract-progress), this brings the implementation here in line with it.

@mafredri mafredri requested review from dannykopping and johnstcn May 30, 2024 14:00
dannykopping
dannykopping approved these changes May 30, 2024
View reviewed changes
Copy link

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @dannykopping @johnstcn