fix: lie about ownership of all files in build context when running as non-root user #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Sep 19, 2024
pkg/util/util.go
Outdated
| // operation is not root. This means that the cache probe operation will | ||
| // fail unless we lie about the UID/GID of the files used to build the | ||
| // image. | ||
| lyingAboutOwnership := !fi.IsDir() && !isRoot() |
There was a problem hiding this comment.
I would like to see this logic moved to a filesystem wrapper, one we set in envbuilder, and only for cache probing. The isRoot check is probably a good approximation to running a cache probe, but it still makes me a bit uneasy. 😅
Should we at least limit this to the workspace directory? (Not sure how we would pass that info over to Kaniko in a clean way, though.)
|
Closing in favour of #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies and builds on our previous lies: