Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

fix(jfrog-token)!: add attributes to fine control the token behaviour #100

Merged
merged 7 commits into from
Nov 15, 2023
Merged

fix(jfrog-token)!: add attributes to fine control the token behaviour #100

merged 7 commits into from
Nov 15, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Nov 15, 2023 •
edited
Loading

  1. Add the check_license attribute to skip the pre-flight license check.
  2. Add the expires_in attribute to control the `expiry time of scoped_tokens used in the workspace.
  3. Make the refreshable attribute an input to control if the tokens are refreshable.
  4. Change the username_filed default value to username instead of email. This will now map the data.coder_workspace.me.owner to username.

    This is the observed behavior on both self-hosted and SaaS Artifactory instances for GitHub and Google OAuth provisioned users. If this is not the case for some customers, they can use this field to change this behavior.

Note

All values default to artifactory_scoped_token default values.

@matifali matifali requested a review from bpmct November 15, 2023 07:56
@matifali matifali changed the title fix(jfrog-token): add check_license attribute to skip pre-flight license check fix(jfrog-token): add attributes to finley control the token behaviour Nov 15, 2023
@matifali matifali changed the title fix(jfrog-token): add attributes to finley control the token behaviour fix(jfrog-token): add attributes to fine control the token behaviour Nov 15, 2023
@matifali matifali requested a review from spikecurtis November 15, 2023 08:03
@matifali matifali changed the title fix(jfrog-token): add attributes to fine control the token behaviour fix(jfrog-token)!: add attributes to fine control the token behaviour Nov 15, 2023
@matifali matifali merged commit 8e3f48c into main Nov 15, 2023
@matifali matifali deleted the jfrog-token branch November 15, 2023 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @bpmct