Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Conversation

Conor-Behard333
Copy link
Contributor

also removes the .git from the basename if the user includes it
closes https://github.com/coder/modules/issues/120

@matifali matifali requested a review from kylecarbs January 20, 2024 13:24
@matifali matifali merged commit 38a2d86 into coder:main Jan 23, 2024
matifali added a commit that referenced this pull request Jan 26, 2024
After #124, we now automatically append the `path` with the `repo` name, so the example should be changed to pass only the base directory as the `path` input.
matifali added a commit to coder/coder that referenced this pull request Jan 26, 2024
…` module

After coder/modules#124, the `git-clone` module automatically appends and creates the path with the repo name, so we need to change the `path` input to specify the `repo_base_dir`. 

The `repo_dir` must still be passed to `code-server` and `jetbrains-gateway` modules and to set the `dir` field of `coder_agent`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow basename of url to be added to custom path in the Git-Clone module
3 participants