This repository was archived by the owner on May 15, 2025. It is now read-only.
fix(vscode-web): set --host 127.0.0.1
#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MS code-server defaults to using `--host localhost`, which was working perfectly fine with Coder. But recently Coder is failing to proxy vscode-web with the coder/coder#12790 As a workaround setting `--host 127.0.0.1` works.
--host 127.0.01--host 127.0.0.1
--host 127.0.0.1--host 127.0.0.1
coadler
approved these changes
Apr 5, 2024
--host 127.0.0.1--host 127.0.0.1
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS code-server defaults to using
--host localhost, which worked perfectly with Coder.But recently Coder is failing to proxy vscode-web with the coder/coder#12790
As a workaround, setting
--host 127.0.0.1works.Details
ok so Running (the default if we skip
--host)/tmp/vscode-web/bin/code-server serve-local --port 13340 --host localhost --accept-server-license-terms serve-local --without-connection-token --telemetry-level errorgivesBut if we set
--host 127.0.0.1This binds to ipv4.
Is this something that changed at Coder or Microsoft?
Because vs code-server was setting --host localhost and did not change any behavior.