Skip to content

feat(git-config): allow data.coder_workspace.me.owner_email to be blank #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

michaelbrewer
Copy link
Contributor

closes #162

@matifali matifali requested a review from mafredri April 11, 2024 15:03
@matifali
Copy link
Member

@michaelbrewer I think we should fix it on the provider side. I just submitted coder/terraform-provider-coder#209 which should resolve the issue.

@michaelbrewer
Copy link
Contributor Author

Yes. That would fix it for module like this.

@michaelbrewer
Copy link
Contributor Author

@matifali - once the provider update is available I can change this to just be the tests :).

@matifali
Copy link
Member

Merging this won't disturb any existing behavior.

@matifali matifali merged commit 892174d into coder:main Apr 14, 2024
2 checks passed
@michaelbrewer michaelbrewer deleted the feat/git-config branch April 14, 2024 22:37
@michaelbrewer
Copy link
Contributor Author

@matifali - once the provider update is available I can change this to just be the tests :).

PR #254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git config 1.0.3 Call to function "coalesce" failed: no non-null, non-empty-string arguments.
2 participants