feat(code-server): add machine settings option #449
Closed
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
requested changes
May 7, 2025
|
Looks like my fetch sync didn't work properly the first go-around. |
|
We are moving to https://github.com/coder/regitsry. Please move your PR there. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves coder/registry#27.
The goal is to provide a method for template owners to configure default
Machine Settingsthat can be overridden by developers viaUser Settingsand repositories viaWorkspace Settings.This option allows template owners to push new settings options with a template release that would not be ignored because the setting file already exists.
Eventually, I would imagine the current
settingsoption will be depreciated in favor of this option.Alternatively, we could hijack that option to operate on the machine level settings before merging this PR.