fix: use a more generic powershell error fragment for Windows probing #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Apr 11, 2025
spikecurtis
approved these changes
Apr 14, 2025
matifali
reviewed
Apr 14, 2025
| @@ -23,7 +23,10 @@ const ( | |||
| // windowsPowershellCommandNotFoundFragment is a fragment of the error output | |||
| // returned on Windows systems running Powershell when a command cannot be | |||
| // found. | |||
| windowsPowershellCommandNotFoundFragment = "is not recognized as the name of a cmdlet, function, script file, or operable program." | |||
| // Different Windows versions use slightly error messages. | |||
There was a problem hiding this comment.
Suggested change
| // Different Windows versions use slightly error messages. | |
| // Different Windows versions use slightly different error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#566
Very very funny to me that someone at Microsoft changed this error message, especially the "a name" <=> "the name".
File sync working:
