Skip to content

Add Heroku deployment. #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 17, 2023
Merged

Add Heroku deployment. #18

merged 8 commits into from
Apr 17, 2023

Conversation

matifali
Copy link
Member

This closes coder/coder#6959

@matifali matifali requested a review from bpmct April 16, 2023 11:06
@matifali matifali self-assigned this Apr 16, 2023
@matifali matifali marked this pull request as draft April 16, 2023 11:27
@matifali matifali marked this pull request as ready for review April 16, 2023 12:51
@matifali
Copy link
Member Author

matifali commented Apr 16, 2023 •
edited
Loading

@bpmct, as the heroku branch has not yet been merged in the main, the button will not work.
Use this button to test: Deploy Coder on Heroku
It deploys from heroku Branch

bpmct
bpmct reviewed Apr 17, 2023
View reviewed changes
bpmct
bpmct reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-04-17 at 9 31 57 AM

I used the button you sent. The build log is just spinning for me. Do you see that?

bpmct
bpmct approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, just a Heroku bug.

@matifali
Copy link
Member Author

Nevermind, just a Heroku bug.

were you able to deploy?

@matifali matifali closed this Apr 17, 2023
@matifali matifali reopened this Apr 17, 2023
@matifali matifali merged commit 478251b into main Apr 17, 2023
@matifali matifali deleted the heroku branch April 17, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpmct bpmct bpmct approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coder as a Heroku app
2 participants
@matifali @bpmct