Skip to content

feat: custom mock logger #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

feat: custom mock logger #21

merged 1 commit into from
Jun 25, 2025

Conversation

basgys
Copy link
Contributor

@basgys basgys commented Jun 23, 2025 •
edited
Loading

Summary

Adds a WithLogger method to the Mock clock that allows customising the logger used for debug output, instead of always using testing.TB. The main motivation is that Quartz can be verbose.

Usage

mClock := quartz.NewMock(t).WithLogger(quartz.NoOpLogger)

@basgys
feat: custom mock logger
6f1d828 
Adds a `WithLogger` method to the Mock clock that allows customising the logger used for debug output, instead of always using `testing.TB`. The main motivation is that Quartz can be verbose.
@basgys basgys mentioned this pull request Jun 23, 2025
Closed
spikecurtis
spikecurtis approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spikecurtis spikecurtis merged commit 3734877 into coder:main Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basgys @spikecurtis