-
Notifications
You must be signed in to change notification settings - Fork 48
Add Proxmox-Vm template #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…up cloud-init and variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I left a few suggestions and it's good to go after that. I also tested.
@DevelopmentCats can you review this too.
script = "coder stat cpu --host" | ||
interval = 10 | ||
timeout = 1 | ||
order = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust order
to. Many of the blocks use the same order value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
interface = "scsi0" | ||
datastore_id = var.disk_storage | ||
size = data.coder_parameter.disk_size_gb.value | ||
ssd = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this work for someone who has HDD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing that out. This block was optional and only controlled disk emulation. I’ve removed it to avoid any confusion.
Co-authored-by: Atif Ali <me@matifali.dev>
Closes #212
/claim #212
Description
Adds a Proxmox VM template
Type of Change
Testing & Validation
bun run fmt
)Screencast.from.2025-08-15.16-46-27.mp4