Skip to content

Add Proxmox-Vm template #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

m4rrypro
Copy link

@m4rrypro m4rrypro commented Aug 15, 2025

Closes #212
/claim #212

Description

Adds a Proxmox VM template

Type of Change

  • New module
  • New template
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Testing & Validation

  • Code formatted (bun run fmt)
  • Changes tested locally
Screencast.from.2025-08-15.16-46-27.mp4

matifali
matifali previously approved these changes Aug 17, 2025
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I left a few suggestions and it's good to go after that. I also tested.

@DevelopmentCats can you review this too.

script = "coder stat cpu --host"
interval = 10
timeout = 1
order = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust order to. Many of the blocks use the same order value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

interface = "scsi0"
datastore_id = var.disk_storage
size = data.coder_parameter.disk_size_gb.value
ssd = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would this work for someone who has HDD?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing that out. This block was optional and only controlled disk emulation. I’ve removed it to avoid any confusion.

Co-authored-by: Atif Ali <me@matifali.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxmox VE VM template
2 participants