fix: synchronize test logs to prevent t.Log race condition
#146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `(*testing.T).Log` is called concurrently of a test exiting, it's picked up by the race detector. This adds logic to allow slogtest to detect when a test has exited, and ensure it doesn't call `(*testing.T).Log` after that happens.
Pull Request Test Coverage Report for Build a64d7100c48aad81449acb051c4d324c4c2336c5-PR-
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
(*testing.T).Logis called concurrently of a test exiting, it'spicked up by the race detector. This adds logic to allow slogtest to
detect when a test has exited, and ensure it doesn't call
(*testing.T).Logafter that happens.