Skip to content

fix: add additional severity field to stackdriver #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

mafredri
Copy link
Member

The logging.googleapis.com/severity field is no longer mentioned in https://cloud.google.com/logging/docs/agent/configuration#special-fields docs, and when viewed in Google Cloud Logging, severity is missing (and inferred from stderr as ERROR).

For this reason, we add the severity field as well. The logging.googleapis.com/severity field is still mentioned in https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/configuration#special-fields, which is why we keep it.

An example configuration on that page suggests rewriting the field (https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/configuration#example_configuration_2), however, this seemed cumbersome to do in our deployment on big.cdr.dev and sending both fields seems like a good compromise.

Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but deferring to @ammario

Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@mafredri mafredri merged commit f0c466f into main Sep 29, 2023
@mafredri mafredri deleted the mafredri/stackdriver-severity branch September 29, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants