Skip to content

Sink context iface #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

Sink context iface #86

merged 1 commit into from
Mar 31, 2020

Conversation

ammario
Copy link
Member

@ammario ammario commented Mar 31, 2020

No description provided.

@ammario ammario requested a review from nhooyr as a code owner March 31, 2020 20:03
@ammario
Revert "Make SinkContext a struct"
6a41f9d 
It's better as an interface so users don't have to call the `Sink`
method on the struct during Make.

- Move SinkContext into context.go
@ammario ammario force-pushed the sink-context-iface branch from b49057c to 6a41f9d Compare March 31, 2020 20:05
@ammario ammario merged commit e88ff39 into master Mar 31, 2020
@ammario ammario deleted the sink-context-iface branch March 31, 2020 20:05
nhooyr added a commit that referenced this pull request Apr 9, 2020
@nhooyr
Revert "Merge pull request #86 from cdr/sink-context-iface"
958f7eb 
This reverts commit e88ff39, reversing
changes made to 95bc0f1.
@dependabot dependabot bot mentioned this pull request Mar 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr Awaiting requested review from nhooyr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ammario