Skip to content

Remove nested Loggers in Make #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove nested Loggers in Make #93

wants to merge 2 commits into from

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Sep 3, 2020

Closes #92

@nhooyr nhooyr requested a review from cmoog September 3, 2020 22:43
@nhooyr
Copy link
Contributor Author

nhooyr commented Jan 25, 2022

@cmoog took care of this in #95

This pr was also a much worse approach.

@nhooyr nhooyr closed this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@cmoog cmoog cmoog approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Named work with nested loggers
2 participants
@nhooyr @cmoog