fix: Guard against conn leak after server close #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Apr 4, 2023
| @@ -124,3 +126,104 @@ func TestServerClose(t *testing.T) { | |||
| return | |||
| } | |||
| } | |||
|
|
|||
| func TestServerClose_ConnectionLeak(t *testing.T) { | |||
There was a problem hiding this comment.
This test is a bit finicky, but without the fix it will usually time out (as a proof of the issue being fixed).
kylecarbs
approved these changes
Apr 6, 2023
coadler
approved these changes
Apr 6, 2023
|
Hey @mafredri! Is this PR still valid? |
|
@mtojek It doesn't necessarily hurt but it's not needed anymore, this was fixed in another way in the agentssh package. Ultimately a more invasive reactor would be better here e.g. if we wanted to contribute it upstream. |
|
Thank you for the quick reply and explanation! I will resolve this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this leak as part of coder/coder#7004
See: https://github.com/coder/coder/actions/runs/4609297757/jobs/8146257114?pr=7004
NOTE: This is mainly a problem when using
Serve, which we were not previously using in coder. However, our previous implementation of starting multiple goroutines for each connection were not ideal either. This fix + usage of Serve should reduce overhead/memory usage when there are many connections.We will also be looking to refactor the implementation as part of coder/coder#6177.