fix: find non stun nodes for websocket fallback #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Mar 21, 2023
| @@ -347,12 +347,23 @@ func (c *Client) connect(ctx context.Context, caller string) (client *derp.Clien | |||
| case c.useWebsockets(): | |||
| var urlStr string | |||
| var tlsConfig *tls.Config | |||
| var node *tailcfg.DERPNode | |||
| for _, n := range reg.Nodes { | |||
There was a problem hiding this comment.
Comment would help for why this loop is necessary
If the first node was a STUN node, it would naturally fail to dial. A user found this and reported it!
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 21, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 21, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 21, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first node was a STUN node, it would naturally fail to dial.
A user found this and reported it!