fix: add websocket fallback when http2 is used #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Mar 23, 2023
7e54a32 to
dbb5185
Compare
mafredri
approved these changes
Mar 23, 2023
dbb5185 to
5734fc5
Compare
HTTP/2 doesn't support the 'Upgrade' header, which breaks the DERP exchange.
5734fc5 to
e25f8e3
Compare
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 23, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 23, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 23, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 24, 2023
kylecarbs
added a commit
to coder/coder
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 doesn't support the 'Upgrade' header, which breaks the DERP exchange.