fix: plan v4/v6 STUN probing based on relative index #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
deansheather
approved these changes
Nov 6, 2023
spikecurtis
added a commit
to coder/coder
that referenced
this pull request
Nov 7, 2023
Fixes STUN probe issues on dual stack systems by incorporating coder/tailscale#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still noticing some instability and my agent isn't probing STUN regions, and therefore failing netchecks.
I've noticed a bug in our planning, introduced with my previous change. The choice of number of probes and v4 vs v6 for the probes was being computed based on the sorted speed index, rather than the relative index of only STUN regions. So, if the first STUN region wasn't in the top 3 by speed, it could only get a single try and/or only v6 probes. In pathological cases, you could end up with only v6 probes and no v4 probes.