fix(wgengine): Guard endpoint dispatcher via wrapper #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92be451 to
f1b4612
Compare
f1b4612 to
c3252ea
Compare
kylecarbs
approved these changes
Feb 25, 2023
|
@kylecarbs its only an issue for us because of one of my patches that fixed a goleak issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix for a42a6f2.
Mimics the fix in upstream gvisor: google/gvisor@13d7bf6
The motivation is that even though we use a mutex in
netstack, we aren't protectingAttachwhich is invoked elsewhere. There are also a few other uses oflinkEPin netstack that weren't protected.