Skip to content

feat: add validation for list(string) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2023
Merged

feat: add validation for list(string) #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b56dc8
feat: add validation for list(string)
mtojek Mar 15, 2023
e3463bf
fix
mtojek Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions provider/parameter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,12 @@ func (v *Validation) Valid(typ, value string) error {
if v.Monotonic != "" && v.Monotonic != ValidationMonotonicIncreasing && v.Monotonic != ValidationMonotonicDecreasing {
return fmt.Errorf("number monotonicity can be either %q or %q", ValidationMonotonicIncreasing, ValidationMonotonicDecreasing)
}
case "list(string)":
var listOfStrings []string
err := json.Unmarshal([]byte(value), &listOfStrings)
if err != nil {
return fmt.Errorf("value %q is not valid list of strings", value)
}
}
return nil
}
Expand Down
15 changes: 15 additions & 0 deletions provider/parameter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,19 @@ func TestValueValidatesType(t *testing.T) {
Min: 0,
Max: 2,
Monotonic: "decreasing",
}, {
Name: "ValidListOfStrings",
Type: "list(string)",
Value: `["first","second","third"]`,
}, {
Name: "InvalidListOfStrings",
Type: "list(string)",
Value: `["first","second","third"`,
Error: regexp.MustCompile("is not valid list of strings"),
}, {
Name: "EmptyListOfStrings",
Type: "list(string)",
Value: `[]`,
}} {
tc := tc
t.Run(tc.Name, func(t *testing.T) {
Expand All @@ -529,6 +542,8 @@ func TestValueValidatesType(t *testing.T) {
if tc.Error != nil {
require.Error(t, err)
require.True(t, tc.Error.MatchString(err.Error()), "got: %s", err.Error())
} else {
require.NoError(t, err)
}
})
}
Expand Down